On Fri, 9 Dec 2022 13:57:00 GMT, Daniel Fuchs <[email protected]> wrote:
>> There are several ways by which an HTTP/2 stream can be closed. Due to the >> built-in asynchronous behavior, and to avoid unnecessary churn when a >> request is cancelled/aborted there are two places where the boolean stream's >> state closed can be set to true: cancelImpl and close. The current code >> completes the subscriber in cancelImpl, but the subscriber should also be >> completed in close. The intermittent failure happens if close gets ever >> called before cancelImpl. >> This patch fixes that. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Integrated review feedback Thank you Daniel for the changes, this looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk20/pull/3
