On Mon, 23 Jan 2023 12:29:16 GMT, Conor Cleary <[email protected]> wrote:

>> ### **Description**
>> When using `HttpURLConnection::setChunkedStreamingMode()`, the current 
>> documentation does not make it clear that the `chunklen` parameter refers to 
>> the amount of bytes sent on the wire per HTTP/1.1 chunk and _not_ the  
>> payload length per chunk. The `chunklen` parameter takes into account the 
>> bytes used for the chunk size header, two CRLF characters and the possible 
>> payload length inclusively.
>> 
>> ### **Summary of Changes & Justification**
>> The API text has been updated to reflect the actual behavior of the method 
>> as described above to avoid a similar bug being submitted in the future and 
>> to make it clear what the `chunklen` parameter specifies.
>> 
>> This change will require a csr.
>
> Conor Cleary has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8287134: Shortened text and corrected typo

The new text looks good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12137

Reply via email to