On Wed, 8 Feb 2023 18:28:17 GMT, Darragh Clarke <[email protected]> wrote:
>> Currently there is a race condition that can allow for too many >> 'idleConnections' in `ServerImpl` >> >> This PR adds a lock to make sure only one connection can be marked Idle at a >> time as well as a test that consistently failed before the change but which >> now passes. > > Darragh Clarke has updated the pull request incrementally with two additional > commits since the last revision: > > - removed unused variable > - changed test to use URIBuilder, fixed print, changed serverimpl to use > sync instead of lock Thank you Darragh for these changes. The current state of the PR (commit 2bbf2876) looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/12413
