On Tue, 28 Mar 2023 18:59:19 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Please find here a trivial change that upgrades the CustomRequestPublisher >> test to use the new HttpTestServer factory methods. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into CustomRequestPublisher-8305095 > - Removed unused imports > - 8305095 test/jdk/java/net/httpclient/CustomRequestPublisher.java line 325: > 323: > 324: https2TestServer = HttpTestServer.create(HTTP_2, sslContext); > 325: https2TestServer.addHandler(new HttpTestEchoHandler(), > "/https2/echo"); Hello Daniel, I don't see this `HttpTestEchoHandler` class anywhere in the current test hierarchy. Is this a new file which was supposed to be included in this PR? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13211#discussion_r1151396551
