On Fri, 7 Apr 2023 13:43:42 GMT, Conor Cleary <[email protected]> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 560:
>>
>>> 558: // response to be read before the Reset is handled in
>>> the case where the client's
>>> 559: // input stream is partially consumed or not consumed
>>> at all by the server.
>>> 560: requestBodyCF.complete(null);
>>
>> Doesn't seem right: if the error code != NO_ERROR we should probably
>> complete the requestBodyCf exceptionally?
>
> There is now a `completeExceptionally(new IOException("..."))` call is if
> `frame.ErrorCode() != NO_ERROR`. Otherwise, `complete(null)` is called.
Agree that this is better behaviour. Should we test for the case where an
ErrorCode is given?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12694#discussion_r1160711400
