On Fri, 21 Apr 2023 01:26:35 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8305906? >> >> As noted in that issue, when IPv6 hosts are involved, the HttpClient on >> certain occasions can end up caching the connection with a key which doesn't >> match with the key which is then used in a subsequent request against the >> same target host. >> >> The commit in this PR now wraps the IPv6 address in a square bracket >> consistently so that the correct key is used both during storing the >> connection in the pool and when looking up. >> >> A new jtreg test has been added which reproduces this issue without the fix >> and verifies the fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > wrapping into brackets is no longer needed LGTM ------------- Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13456#pullrequestreview-1395115657
