On Wed, 26 Apr 2023 15:51:27 GMT, Daniel Fuchs <[email protected]> wrote:
> The tests test/jdk/java/net/httpclient/*InURI.java create a lot of HttpClient
> instances.
> They should call HttpClient::close when the client is no longer needed.
>
> The fix includes some cleanup of the test code, as well as an additional
> check on the response version.
LGTM.
test/jdk/java/net/httpclient/EscapedOctetsInURI.java line 279:
> 277: public void handle(HttpTestExchange t) throws IOException {
> 278: String asciiUriString = t.getRequestURI().toASCIIString();
> 279: out.println("Http2ASCIIUriString received, asciiUriString: "
> + asciiUriString);
Suggestion:
out.println("HttpASCIIUriString received, asciiUriString: " +
asciiUriString);
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13673#pullrequestreview-1403268111
PR Review Comment: https://git.openjdk.org/jdk/pull/13673#discussion_r1178671412
