On Wed, 10 May 2023 16:19:00 GMT, Daniel Fuchs <[email protected]> wrote:
> java/net/httpclient/FlowAdapterPublisherTest.java and
> java/net/httpclient/FlowAdapterSubscriberTest.java create one HttpClient
> instance per test method. The test should use try-with-resources to close the
> client instances.
test/jdk/java/net/httpclient/FlowAdapterPublisherTest.java line 100:
> 98: }
> 99:
> 100: private HttpClient newHttpClient(String uri) {
Hello Daniel, the `uri` param doesn't seem to be used in this method.
Same in the other test class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13909#discussion_r1190662233
