On Tue, 16 May 2023 13:36:15 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change in the > `jdk.httpclient.test.lib.http2.Http2TestServerConnection` which proposes to > use the `SSLSocket.startHandshake()` to API propogate any handshake > exception back to the test that uses this test server? > > This addresses https://bugs.openjdk.org/browse/JDK-8308185 and as noted in > that JBS issue should help diagnoze any handshake failures in httpclient > tests, a bit more easily. > > tier2 testing with this change came back without any failures. This pull request has now been integrated. Changeset: 1a6f9810 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/1a6f9810cd5bcd3cdbdd1505900c0e8c7f091b22 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake() Reviewed-by: djelinski ------------- PR: https://git.openjdk.org/jdk/pull/14012
