On Mon, 22 May 2023 12:52:49 GMT, Daniel Fuchs <[email protected]> wrote:

> The test `test/jdk/java/net/httpclient/ShutdownNow.java` has been observed 
> failing intermittently (though rarely) with an assertion error: 
> `java.lang.AssertionError: 0: Unexpected exception: java.io.IOException: 
> Stream 1 cancelled` caused by  
> 
> 
> java.io.IOException: Stream 1 cancelled
> at java.net.http/jdk.internal.net.http.Stream.cancel(Stream.java:1285) 
> 
> 
> Given the nature of the test - which interrupts / cancel all operations 
> asynchronously, then a "stream %d cancelled" exception should count as an 
> acceptable result.

The change looks OK to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14081#pullrequestreview-1438673832

Reply via email to