On Wed, 24 May 2023 11:39:26 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a change that revisits usage of monitors in the HttpClient. >> >> With Virtual Threads now part of the platform it should be possible to pass >> a newVirtualThreadPerTaskExecutor to the HttpClient. Logging, when enabled, >> and when called from a synchronized block, can cause the carrier thread to >> get pinned in case of contention when printing through the underlying >> PrintStream. >> >> This change aims at avoiding situations where the carrier threads might get >> pinned. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Review feedback The tests that have been selectively changed to use virtual threads for the HttpClient (and have been set with `-Djdk.tracePinnedThreads=full`), I'm guessing were selected based on some of the failures that were noticed when virtual threads were used? ------------- PR Comment: https://git.openjdk.org/jdk/pull/14038#issuecomment-1560975920
