On Tue, 30 May 2023 15:57:55 GMT, Daniel Fuchs <[email protected]> wrote:

> Please find below a fix for a regression observed in the HttpClient 
> AsyncShutdownNow test, after 
> [JDK-8308310](https://bugs.openjdk.org/browse/JDK-8308310)
> 
> The PlainHttpConnection should have been modified to use a ReentrantLock 
> instead of trying to perform potentially blocking actions outside of the 
> synchronized block.
> 
> I also took this opportunity to fix the regex in the code that validate the 
> exception message. The IOException thrown in that case has "Stream" with a 
> capital "S".

The change looks OK to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14223#pullrequestreview-1452862037

Reply via email to