On Tue, 6 Jun 2023 09:19:20 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:

> Please review this change to introduce buffering in the tunnelling proxy 
> implementations.
> 
> Copying network data one byte at a time is very inefficient. 
> ProxyAuthDisabledSchemesSSL is 10 seconds faster (from 40 down to 30s) on my 
> Windows machine with these changes.
> 
> I did not quantify the improvements in other tests affected by this change; I 
> only verified that they continue to pass.

Hello Daniel, these changes look good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14329#pullrequestreview-1466701145

Reply via email to