On Thu, 8 Jun 2023 14:09:01 GMT, Darragh Clarke <[email protected]> wrote:

>> `HttpURLConnectionExpectContinueTest` was throwing an error due to port 
>> being hardcoded, updated test to let the system decide which port to use.
>
> Darragh Clarke has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   implemented feedback

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java 
line 31:

> 29:  * @run junit/othervm HttpURLConnectionExpectContinueTest
> 30:  * @run junit/othervm -Djava.net.preferIPv4Stack=True 
> HttpURLConnectionExpectContinueTest
> 31:  * @run junit/othervm -Djava.net.preferIPv6Addresses=True 
> HttpURLConnectionExpectContinueTest

Suggestion:

 * @run junit/othervm -Djava.net.preferIPv4Stack=true 
HttpURLConnectionExpectContinueTest
 * @run junit/othervm -Djava.net.preferIPv6Addresses=true 
HttpURLConnectionExpectContinueTest

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14177#discussion_r1223190801

Reply via email to