On Mon, 19 Jun 2023 16:34:10 GMT, Daniel Fuchs <[email protected]> wrote:
> Please find here a change that makes sure that debugging interestOps/readyOps
> won't cause exceptions to be raised.
> The change also contains smaller cleanup: extracting ALPN contants to their
> own class, removing/adding newlines at end of files, avoiding long lines in
> some occasions, removing some unused imports, etc...
LGTM. 2 minor issues reported in line. Please update copyright before
integrating.
src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line
294:
> 292: String[] alpn = null;
> 293: if (version == HTTP_2 &&
> hasRequiredHTTP2TLSVersion(client)) {
> 294: alpn = new String[] {Alpns.H2, Alpns.HTTP_1_1 };
Suggestion:
alpn = new String[] { Alpns.H2, Alpns.HTTP_1_1 };
src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java
line 282:
> 280: && logger.isLoggable(level)) {
> 281: logger.log(level, unused,
> 282: format(new StringBuilder(), msg, null).toString(),
`getFormat` is no longer used, can you remove it?
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14546#pullrequestreview-1486842723
PR Review Comment: https://git.openjdk.org/jdk/pull/14546#discussion_r1234422071
PR Review Comment: https://git.openjdk.org/jdk/pull/14546#discussion_r1234802376
