On Fri, 23 Jun 2023 12:36:47 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this test-only change which addresses 
> https://bugs.openjdk.org/browse/JDK-8310731?
> 
> As noted in that issue, before the changes in this PR, the test servers that 
> we created for HTTP/1.1 testing in `java/net/httpclient` tests weren't 
> configured to use a `javax.net.ssl.SNIMatcher` which resulted in the SNI name 
> extension from the client being ignored. The commit in this PR addresses that 
> by configuring such instances with a relevant `SNIMatcher`. 
> 
> No new tests have been added given the nature of this change, but existing 
> tests in `java/net/httpclient` continue to pass with this change.

Thank you Daniel for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14626#issuecomment-1609274929

Reply via email to