On Fri, 19 May 2023 16:14:19 GMT, Jesse Glick <d...@openjdk.org> wrote:
>> Jesse Glick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Leaving `FileURLConnection.is` non-null, and claiming `connected`, even >> after `closeInputStream` >> https://github.com/openjdk/jdk/pull/12871#discussion_r1199085883 > > Ran > > > make test TEST=:jdk_net > > > on Linux. Only failures are > > > java/net/DatagramSocket/DatagramSocketExample.java Error. Program > `…/jdk/build/linux-x86_64-server-release/images/jdk/bin/java' timed out > (timeout set to 480000ms, elapsed time including timeout handling was > 480197ms). > java/net/DatagramSocket/DatagramSocketMulticasting.java Error. Program > `…/jdk/build/linux-x86_64-server-release/images/jdk/bin/java' timed out > (timeout set to 480000ms, elapsed time including timeout handling was > 480221ms). > java/net/MulticastSocket/Promiscuous.java Failed. Execution > failed: `main' threw exception: java.lang.RuntimeException: > /[0:0:0:0:0:0:0:0]:58774: Expected message not received, Receive timed out > java/net/MulticastSocket/PromiscuousIPv6.java Failed. Execution > failed: `main' threw exception: java.lang.RuntimeException: Expected message > not received, Receive timed out > java/net/MulticastSocket/SetLoopbackMode.java Failed. Execution > failed: `main' threw exception: java.lang.RuntimeException: Test failed > java/net/MulticastSocket/SetLoopbackModeIPv4.java Failed. Execution > failed: `main' threw exception: java.lang.RuntimeException: Test failed > java/net/MulticastSocket/SetOutgoingIf.java Failed. Execution > failed: `main' threw exception: java.lang.RuntimeException: > java.net.SocketTimeoutException: Receive timed out > java/net/MulticastSocket/Test.java Failed. Execution > failed: `main' threw exception: java.lang.Exception: Test failed - see log > file for details > > > Since > > > git checkout master > make clean images test TEST=java/net/MulticastSocket/Promiscuous.java > > > fails similarly, I presume these are unrelated, perhaps something about my > network configuration. > > I have no more changes planned. Hi @jglick sorry for the long time this took to review. I'm happy with the proposed change as they are. If you `/integrate` them then @Michael-Mc-Mahon or I will sponsor. ------------- PR Comment: https://git.openjdk.org/jdk/pull/12871#issuecomment-1610993125
