On Wed, 19 Jul 2023 12:00:48 GMT, Jaikiran Pai <[email protected]> wrote:
> The changes to `WindowsSocketOptions.java` which are merely wiring changes, > look OK to me. I don't have experience with Windows nor much JNI code, so > I'll let other reviewers take a look. > > I see that the JNI code is updated to use `WSAGetLastError()` instead of > `errno` to get the error code. You already provided a link to the > documentation of that API and reading through it, it appears to be the right > thing to do and it seems to be supported on all relevant Windows versions of > interest. However, that change does impact other existing code in that file. > Do you think we could do that change in a separate PR? > > In the meantime, could you please update the copyright year on both these > changed files to `2022, 2023, ` from the current `2022, `? I think it is right to change the `errno` to `WSAGetLastError`. There is an errno.h in VC++ which must be getting included indirectly. It is used in hotspot. But, we shouldn't be using it in the networking code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14232#issuecomment-1642435942
