On Tue, 30 May 2023 22:46:05 GMT, Terry Chow <[email protected]> wrote:
> The PR adds support for the keepalive extended socket options on Windows. For > TCP_KEEPIDLE and TCP_KEEPINTVL, these options are supported starting from > Windows 10 version 1709. TCP_KEEPCNT is supported starting from Windows 10 > version 1703. Information on these socket options can be found > [here](https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options). > > I've also corrected the `handleError()` function. On Windows, the error needs > to be retrieved using `WSAGetLastError()` and error codes are prefixed with > "WSA". Information on this can be found > [here](https://learn.microsoft.com/en-us/windows/win32/winsock/error-codes-errno-h-errno-and-wsagetlasterror-2). > >>The error codes returned by Windows Sockets are similar to UNIX socket error >>code constants, but the constants are all prefixed with WSA. > >>Error codes set by Windows Sockets are not made available through the errno >>variable. > > No new tests were added as the existing tests should cover this. This pull request has now been integrated. Changeset: f3ade388 Author: Terry Chow <[email protected]> Committer: Michael McMahon <[email protected]> URL: https://git.openjdk.org/jdk/commit/f3ade388dac0b882e671462caa762138f44817fb Stats: 210 lines in 9 files changed: 169 ins; 0 del; 41 mod 8308593: Add Keepalive Extended Socket Options Support for Windows Reviewed-by: michaelm, djelinski, vtewari ------------- PR: https://git.openjdk.org/jdk/pull/14232
