On Thu, 27 Jul 2023 08:28:34 GMT, Daniel Jeliński <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor cleanup to simplify the code > > src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java > line 134: > >> 132: private static final int MAX_CLIENT_STREAM_ID = Integer.MAX_VALUE; >> // 2147483647 >> 133: private static final int MAX_SERVER_STREAM_ID = Integer.MAX_VALUE - >> 1; // 2147483646 >> 134: private volatile IdleConnectionTimeoutEvent >> idleConnectionTimeoutEvent; // may be null > > What was the reason for this change? `idleConnectionTimerEvent` is always > protected by `stateLock`. Hello Daniel, you are right. I missed cleaning up that part from my early experiments. I'll fix that and do the necessary changes shortly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15012#discussion_r1275995966
