On Thu, 14 Sep 2023 19:18:13 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a patch for a very rare intermittent failure observed in >> CancelRequestTest. >> >> The fact that the number of pending requests hasn't been decremented leads >> me to think that completable future returned by sendAsync (called from send) >> hasn't been fully completed. That is, the dependent actions registered by >> sendAsync have not been run within the timeout waiting for the number of >> pending requests to reach 0. >> >> The fix is to call cf.get() again after calling cf.cancel(), and increase >> the timeout waiting for cleanup in testPostInterrupt. >> client.close() is also called at the end of each test method to reclaim >> resources earlier > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Revert changes to HttpClientImpl.java > - Merge branch 'master' into CancelRequest-8314136 > - 8314136 Hello Daniel, this latest change to increase the timeout slightly to 2000 and also closing the HttpClient instances looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15249#pullrequestreview-1628235407
