> Hi, > > Please find below a fix for 8316580: HttpClient with StructuredTaskScope does > not close when a task fails. > > The problem here is a subtle reference release issue: Interrupting the > VirtualThread means that the CompletableFuture returned by sendAsync is > eligible for GC after having been cancelled, which in turn means that some of > the intermediate operations that would have been completed before that CF was > completed get eligible for being GC’ed too. One of these intermediate > operations is the action that decrements the ref counting. Since the refcount > isn’t decremented properly, the client won’t exit. > > Holding onto the CompletableFuture returned to the caller by > HttpClient::sendAsync until that CompletableFuture gets completed from > upstream fixes the issue.
Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision: - Update test/jdk/java/net/httpclient/HttpGetInCancelledFuture.java Co-authored-by: Andrey Turbanov <[email protected]> - Update test/jdk/java/net/httpclient/HttpGetInCancelledFuture.java Co-authored-by: Andrey Turbanov <[email protected]> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/15883/files - new: https://git.openjdk.org/jdk/pull/15883/files/587649ee..d0e77c76 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15883&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15883&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15883.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15883/head:pull/15883 PR: https://git.openjdk.org/jdk/pull/15883
