On Tue, 10 Oct 2023 15:40:49 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - updates for Inet6Address.ofLiteral return type, javadoc and the
>> regression test
>> - add null checks and NPE to methods javadoc
>
> src/java.base/share/classes/java/net/Inet6Address.java line 525:
>
>> 523: * parsed as an IPv6 address literal.
>> 524: * @throws NullPointerException if the {@code ipv6AddressLiteral}
>> is {@code null}.
>> 525: */
>
> Similar comment to Inet4Address. The snippet should be incorporated into the
> general class docs section "Textual representation of IP addresses" and the
> apidoc here should limit itself to any limitations that only apply to this
> method imo.
My mistake, it looks like we don't support the octal or hexadecimal formats in
the existing `getByName` method, which is good news!
But, I think the comments above still apply in terms of moving the snippets to
the class level docs, and maybe specifying there also that we only support the
decimal literals
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15775#discussion_r1352862018
