On Mon, 16 Oct 2023 09:21:52 GMT, Daniel Jeliński <[email protected]> wrote:

> `ProxySelector.select` and `connectFailed` methods should throw 
> `IllegalArgumentException`s on null parameters.
> 
> Additionally, the `select` method doesn't need to be synchronized - the 
> selector is immutable.
> 
> Tier2 green.

The change to the source and the migration of the test to junit looks fine to 
me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16199#pullrequestreview-1679678256

Reply via email to