On Thu, 16 Nov 2023 15:52:02 GMT, Matthias Baesken <[email protected]> wrote:
>> There are a few places in the JDK C coding where the setsocktopt return >> value is not handled but better should be handled. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > do not change old legacy src/java.base/unix/native/libnet/SdpSupport.c Looks fine, if you are doing any further edits then I think the Windows code should check for SOCKET_ERROR rather than < 0. ------------- PR Review: https://git.openjdk.org/jdk/pull/16684#pullrequestreview-1738299737
