On Mon, 20 Nov 2023 10:51:11 GMT, Daniel Fuchs <[email protected]> wrote:
>> Hello Daniel, I've updated the PR to slightly improve the current proposed >> form to address the part that the encrypt/decrypt are independent. To me, >> the old diagram wasn't clear enough on what represented upstream/downstream >> (given that the directions were horizontal), plus what kind of data the >> upstream/downstream received. >> >> Do you think in the updated version of this PR, the diagram addresses this >> review comment? If not, I'll update the PR further to include the original >> diagram too. > > I think you will need to invert the right hand side of the new diagram: for > reading, upstream is below, while for writing, upstream is above. I see what you mean. I've updated the PR accordingly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16704#discussion_r1399320453
