On Thu, 23 Nov 2023 11:18:17 GMT, Darragh Clarke <[email protected]> wrote:
>> Currently the descriptions of `URLEncoder.encode` and `URLDecoder.decode` >> don't specify their use of replacement bytes or replacement character when >> they cannot handle a character or sequence of bytes. This is longstanding >> behavior but needs to be documented. >> >> **Solution** >> - Added a new line to `URLEncoder.encode` API documentation to document that >> the charset's replacement bytes are used. >> >> - Also changed `URLDecoder.decode` API documentation to document its use of >> the charset's replacement character, also changed some wording. > > Darragh Clarke has updated the pull request incrementally with two additional > commits since the last revision: > > - cleanup > - implemented feedback LGTM. Maybe wait until @AlanBateman has had a chance to re-review before integrating. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16709#pullrequestreview-1746848718
