On Tue, 24 Oct 2023 15:33:34 GMT, Michael McMahon <[email protected]> wrote:

> A test is not included here as it requires testing against real servers that 
> aren't publicly accessible.

It would be nice if there were tests that spun up a test realm and KDC.  [MIT 
Kerberos](https://github.com/krb5/krb5) and 
[Heimdal](https://github.com/heimdal/heimdal) do that, so OpenJDK surely could 
also do that.  Indeed, `test/jdk/sun/security/krb5/auto/KDC.java` and 
`test/jdk/sun/security/krb5/auto/OneKDC.java` do just that -- I just found out 
about these, and I'm rather pleased with it.

A better reason to not include a test is that the bug is non-deterministic, so 
a test success wouldn't prove that the bug is fixed.  To test this there would 
have to be a way to induce 100% likelihood of hitting the original bug, and 
right not I'm not sure how one would do that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16347#issuecomment-1828748599

Reply via email to