On Sat, 13 Jan 2024 08:46:50 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which removes unused code from >> `sun.net.www.protocol.jar.URLJarFile` and removes >> `sun.net.www.protocol.jar.URLJarFileCallBack`? >> >> As noted in the linked issue https://bugs.openjdk.org/browse/JDK-8323645 the >> `sun.net.www.protocol.jar.URLJarFileCallBack` was relevant and used only by >> Java Plugin code (the "deploy" module in JDK 8) which hasn't been in the JDK >> for several releases now. Effectively this interface and its sole usage in >> an internal class of the JDK has been a leftover. >> >> The commit in this PR removes that leftover code. No new tests have been >> added, given the nature of this change. tier1, tier2, tier3 continue to pass >> with this change. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - merge latest from master branch > - 8323645: Remove unused internal > sun.net.www.protocol.jar.URLJarFileCallBack interface This looks reasonable to me: it removes dead code and add some simplification. We can always reintroduce something like that if we ever need it again. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17396#pullrequestreview-1843227346
