On Wed, 20 Mar 2024 17:42:34 GMT, Daniel Fuchs <[email protected]> wrote:

>> Please find here a doc-only change that tries to better document how 
>> resources allocated by the HttpClient are reclaimed.
>> The `@implNote` in the HttpClient class level API documentation is extended 
>> to document what happens if you don't explicitly close the HttpClient. The 
>> note is refactored to introduce the notion of streaming or publishing 
>> bodies. BodySubscribers and BodyHandlers now have links that link back to 
>> the HttpClient API note, as well as identifying methods that return 
>> publishing or streaming body implementations.
>
> Daniel Fuchs has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Update src/java.net.http/share/classes/java/net/http/HttpResponse.java
>    
>    Co-authored-by: Michael McMahon 
> <[email protected]>
>  - Update src/java.net.http/share/classes/java/net/http/HttpResponse.java
>    
>    Co-authored-by: Michael McMahon 
> <[email protected]>
>  - Update src/java.net.http/share/classes/java/net/http/HttpClient.java
>    
>    Co-authored-by: Michael McMahon 
> <[email protected]>

LGTM

-------------

Marked as reviewed by michaelm (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18270#pullrequestreview-1951696633

Reply via email to