On Sat, 6 Apr 2024 09:10:10 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove some @see from constructors
>
> src/java.base/share/classes/java/net/ServerSocket.java line 189:
>
>> 187: * factory, that {@linkplain SocketImplFactory#createSocketImpl()
>> 188: * factory's createSocketImpl method} is called to create
>> 189: * the actual socket implementation. Otherwise a system-default
>
> I think this would be better if you link "server socket implementation
> factory" to SocketImplFactory, and link "createSocketImpl" to the
> createSocketImpl method.
Done - I've updated the PR with these changes to both ServerSocket and Socket
class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18646#discussion_r1554793874
