On Fri, 19 Apr 2024 09:08:54 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> robert engels has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update based on PR review
>
> test/jdk/com/sun/net/httpserver/bugs/B6968351.java line 70:
>
>> 68: long start = System.currentTimeMillis();
>> 69: for(int i=0;i<1000;i++) {
>> 70: var response = client.send(HttpRequest.newBuilder(new
>> URI("http://localhost:"+server.getAddress().getPort()+"/test")).build(),
>> HttpResponse.BodyHandlers.ofString());
>
> It would be better to use the URI builder here and avoid "localhost:port"
> form to avoid dependencies on local host machines configuration.
>
>
> var uri =
> URIBuilder.newBuilder().scheme("http").loopback().port(...).path(...).build();
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1572526178
