On Wed, 24 Apr 2024 10:12:49 GMT, Daniel Jeliński <[email protected]> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Simplify the test further >> - Merge branch 'master' into JDK-8330523 >> - Small further cleanup >> - JDK-8330523 > > test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 113: > >> 111: >> 112: private CountDownLatch serverLatch = new CountDownLatch(1); >> 113: private Thread server; > > this can be converted to a local variable easily OK, did this and using virtual threads now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18817#discussion_r1578996480
