On Tue, 23 Apr 2024 19:10:48 GMT, robert engels <d...@openjdk.org> wrote:
>> fix bug JDK-B6968351 by avoiding flush after response headers > > robert engels has updated the pull request incrementally with one additional > commit since the last revision: > > fix broken test cases test/jdk/com/sun/net/httpserver/bugs/TcpNoDelayNotRequired.java line 29: > 27: * @summary tcp no delay not required for small payloads > 28: * @library /test/lib > 29: * @run main/othervm/timeout=5 -Dsun.net.httpserver.nodelay=false > TcpNoDelayNotRequired I think we should remove the `timeout=5` here. In the past we have seen that such timeouts have contributed to intermittent failures in the CI. jtreg itself has a (sufficiently large) timeout and if the test doesn't complete by then, then jtreg errors that test as timed out. Relying on jtreg timeout handling will avoid guessing the right timeout value here in the test definition. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579362839
