On Fri, 7 Jun 2024 15:21:56 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> The test failed because the shared HttpClients were not garbage collected in > the imparted time. > The timeout of 500ms to wait for the clients to clean up is sufficient most > of the time but rather small, I suspect a bit more time was needed in that > instance. > > The fix raises the timeout to 1500ms. Marked as reviewed by jpai (Reviewer). test/jdk/java/net/httpclient/ForbiddenHeadTest.java line 384: > 382: authClient = noAuthClient = null; > 383: Thread.sleep(100); > 384: AssertionError fail = TRACKER.check(1500); We have other tests where we use a higher timeout like this. So I think it's OK to increase this value to try and prevent this failure. ------------- PR Review: https://git.openjdk.org/jdk/pull/19600#pullrequestreview-2104889969 PR Review Comment: https://git.openjdk.org/jdk/pull/19600#discussion_r1631400098
