On Sat, 15 Jun 2024 03:33:23 GMT, robert engels <d...@openjdk.org> wrote:
>> robert engels has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into >> HttpExchange-api-change >> >> # Conflicts: >> # >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java >> - update api changes based on comments > > Can we ask “do these changes make things better”? I think they do. They’re > not perfect - the additional methods would be much better. > @robaho I think it makes the API very _slightly_ better, but in a way that > would detract from future attempts to make the API holistically better to use. How does it detract from future attempts exactly? It is only adding some constants. If you remove the method, you can remove the constants. If you add additional methods as I proposed the constants can stay and be deprecated, just as we would deprecate the old method. I am not following your reasoning. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18955#issuecomment-2180934442
