On Wed, 26 Jun 2024 14:35:57 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:

> Currently HttpUrlConnection accepts truncated responses: if the server sends 
> a `Content-Length` header, and then closes the connection before transferring 
> all promised bytes, the input stream reports a clean EOF.
> 
> In this PR I modify the MeteredStream class to throw an IOException when it 
> detects EOF before receiving all promised response bytes. MeteredStream (or 
> its subclass KeepAliveStream) is used when the response contains a 
> content-length header.
> 
> The included test fails without the change, passes with it.
> The same exception message and type is reported when a chunked response 
> (`Transfer-Encoding: chunked`) is truncated.
> Unknown length responses that are terminated by EOF continue to work.
> 
> 2 tests depended on the old behavior and had to be adjusted. The remaining 
> tier 1-3 tests continue to pass.

Verified the patch locally. Works for me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19909#issuecomment-2194591817

Reply via email to