On Tue, 9 Jul 2024 06:40:26 GMT, finalchild <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Incorporoted review comments
>> - Merge branch 'master' into proxy-server-auth-8262027
>> - Reworked ProxyServer to reuse the connection in case it can detect that
>> there will be no request body
>> - Merge branch 'master' into proxy-server-auth-8262027
>> - Added blank line
>> - Fixed trailing white spaces
>> - Remove commented code in test
>> - 8262027: Improve how HttpConnection detects a closed channel when
>> taking/returning a connection to the pool
>
> if (!secure) {
> c = pool.getConnection(false, addr, proxy);
> if (c != null && c.checkOpen() /* may have been eof/closed when in the
> pool */) {
> ...
> } else {
> ...
> }
> } else { // secure
> if (version != HTTP_2) { // only HTTP/1.1 connections are in the pool
> c = pool.getConnection(true, addr, proxy);
> }
> if (c != null && c.isOpen()) { <-------------------------------- Why
> is this still isOpen()?
> ...
>
>
> I wonder why the additional check wasn't added to the HTTPS branch. Can
> someone enlighten me?
Hello @finalchild, are you running into some specific issue because of that
`if` block in its current form?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/2649#issuecomment-2227348913
