On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke <dcla...@openjdk.org> wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request >> which includes `Expect: 100-Continue` >> >> Section 10.1.1 of [rfc >> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that >> >> a client SHOULD NOT wait for an indefinite period before sending the content. >> >> >> >> This PR changes `HttpClient` to wait for a maximum of 5 seconds for a server >> response, this will be shorter if a timeout is set. If no response is >> received, the message will be sent regardless. >> This should bring `HttpClient` in line with how >> [HttpUrlConnection](https://github.com/DarraghClarke/jdk/blob/61386c199a3b29457c002ad31a23990b7f6f88fd/src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java#L1305) >> treats expect continue timeouts. >> >> This is done using `orTimeout` in the `expectContinue` method , though there >> is some changes in `streams.java` where it was possible for race conditions >> to cause timeouts where `CompleteableFuture`s were removed from >> `response_cfs` prematurely or in some cases not removed at all. >> >> I've tested this against tiers 1-3 and it appears to be stable. > > Darragh Clarke has updated the pull request incrementally with one additional > commit since the last revision: > > remove duplicate method src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 465: > 463: > 464: return ex.getResponseAsync(parentExecutor) > 465: .orTimeout(responseTimeout, TimeUnit.SECONDS) Hello Darragh, would it be wise to check for the `responseTimeout` to be greater than `0`? I see that we set it to the request timeout value above and if the request timeout is say 500 milli seconds, then `responseTimeout` will end up being `0`. `CompletableFuture.orTimeout()` doesn't specify how it deals with `0` or negative time value to the parameter of that method. So I think we might have to do some checks here to avoid passing `0`. Maybe we should just use nanos as a time unit? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20525#discussion_r1716644217
