On Tue, 13 Aug 2024 08:17:23 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's suggestion > > src/java.base/share/classes/java/net/DatagramSocket.java line 427: > >> 425: * <p> If this socket is already connected, then this method will >> attempt to >> 426: * connect to the passed address and if that attempt completes >> exceptionally, >> 427: * then this socket will continue to be connected to the previously >> connected address. > > I don't know if there are other implementations DatagramSocketImpl in the eco > system but the text could potentially invalidate them. I think it would be > better to say that if connect fails then the state of the DatagramSocket is > unknown, it may or may not be connected to the address that it was previously > connected to. Hello Alan, > I don't know if there are other implementations DatagramSocketImpl in the eco > system but the text could potentially invalidate them. I hadn't taken into account other implementations. I've now updated the PR to use the text that you suggested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20543#discussion_r1716750595
