On Wed, 25 Sep 2024 18:28:02 GMT, Justin Lu <j...@openjdk.org> wrote:

>> Please review this PR which removes usages of Applet within the corelibs 
>> tests.
>> 
>> Most changes are removed comments/updated var names. The JBS issue lists 
>> more files than the ones included in this pull request, please see the 
>> comment on the JBS issue for the reason why they were not included.
>
> Justin Lu has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains three additional commits since 
> the last revision:
> 
>  - update TEST.groups with DefaultTimeZoneTest.java removal
>  - Merge branch 'master' into JDK-8340326-tests-appletRemoval
>  - init

Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to me. 
It's a manual test that involves underlying OS settings manipulation which 
cannot be automated.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21096#pullrequestreview-2329580972

Reply via email to