On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >> comment on the JBS issue for the reason why they were not included. >> >> The following files were removed, >> >> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html >> - Test runner is no longer an Applet, so not needed >> - test/jdk/java/net/Socket/SocketImplTest.java >> - An old Applet test missing Jtreg tags. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > revert bugID update to tests test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 32: > 30: * correctly on Windows. This is a manual test dependent on making > changes to > 31: * the platform setting of the machine and thus cannot be automated. > 32: * @library /java/awt/regtesthelpers You are missing "@build PassFailJFrame". Per https://openjdk.org/jtreg/tag-spec.html - In general, classes in library directories are not automatically compiled as part of a compilation command explicitly naming the source files containing those classes. A test that relies upon library classes should contain appropriate @build directives to ensure that the classes will be compiled. It is strongly recommended that tests do not rely on the use of implicit compilation by the Java compiler. Such an approach is generally fragile, and may lead to incomplete recompilation when a test or library code has been modified. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21096#discussion_r1786644201
