On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu <j...@openjdk.org> wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`.
Hi Justin, Overall looks fine. I t looks like open/src/java.base/share/native/libzip/Deflater.c open/src/java.base/share/native/libzip/Inflater.c also same for line 670 in open.bk/src/java.base/share/native/libjli/java.c were left out from the commit for the PR but are listed in the JBS issue so it would be great to include the updates as part of this PR or explain why they were excluded if it was intentional ------------- Changes requested by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21428#pullrequestreview-2359952631
