On Wed, 16 Oct 2024 13:46:18 GMT, Daniel Jeliński <[email protected]> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated apidoc
>
> test/jdk/java/net/httpclient/UserAuthWithAuthenticator.java line 150:
>
>> 148: HttpResponse<String> resp = client.send(req,
>> HttpResponse.BodyHandlers.ofString());
>> 149: if (useHeader) {
>> 150: assertTrue(h.authValue() == null, "Expected user set
>> header to be set");
>
> authValue is null if the handler was never called; is that what we want to
> check here?
That doesn't look right. I will check that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21408#discussion_r1803238774
