On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties that allow to initialize flow >> control windows are handled, by documenting the full range of valid values >> (when applicable) and explaining what happens if the property points to a >> value that is out of range. >> >> Bad flow control values in the SETTINGS frame will also cause a >> FLOW_CONTROL_ERROR to be reported. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Apply suggestions from code review > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java line 107: > 105: * the bytes from the flow control window. > 106: * > 107: * @implSpec Is it intentional to use `@implSpec` here on an internal class. Or is it just to convey the intention? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21567#discussion_r1810801210
