On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs >> in `java.base`. >> >> This was authored and proposed as #13336 by @jonathan-gibbons as part of an >> effort to [add `@spec` tags and an external specifications page to API >> documentation][JDK-8296546]. The original PR was reviewed and approved, yet >> for some reason it was never integrated. >> >> [JDK-8296546]: https://bugs.openjdk.org/browse/JDK-8296546 >> >> Since I couldn't reopen Jon's PR I created a new pull request based the >> original commits. They still apply cleanly, and I made sure all links are >> still valid and working. I added a commit to update the copyright header >> dates. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright header dates Is "https://tools.ietf.org/html/rfc8103"; considered external spec? It is mentioned in com.sun.crypto.provider.ChaCha20Poly1305Parameters class but not covered in this PR. Is there any additional condition for an external reference to be included? How about an external reference to a section of a specification? E.g. http://www.w3.org/TR/xmlenc-core/#sec-Alg-SymmetricKeyWrap in com.sun.crypto.provider.DESedeWrapCipher class which is also not covered by this PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21326#issuecomment-2433476346
