On Thu, 24 Oct 2024 14:29:45 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs >> in `java.base`. >> >> This was authored and proposed as #13336 by @jonathan-gibbons as part of an >> effort to [add `@spec` tags and an external specifications page to API >> documentation][JDK-8296546]. The original PR was reviewed and approved, yet >> for some reason it was never integrated. >> >> [JDK-8296546]: https://bugs.openjdk.org/browse/JDK-8296546 >> >> Since I couldn't reopen Jon's PR I created a new pull request based the >> original commits. They still apply cleanly, and I made sure all links are >> still valid and working. I added a commit to update the copyright header >> dates. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Add @spec tags as per review feedback src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 303: > 301: * for information about standard algorithm names. > 302: * > 303: * @spec security/standard-names.html Java Security Standard > Algorithm Names There are more than 1 mentioning of the `Java Security Standard Algorithm Names` spec in this class. Do you know why only this one is covered by the @spec tag? Is it due to that the rest of the references contain "#" indicating a segment of the spec? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21326#discussion_r1817381030
