On Thu, 14 Nov 2024 12:57:25 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:

> Please review this PR which removes uses of `AccessController::doPrivileged` 
> in `sun/net/ftp`.
> 
> Changes are mostly straightforward, one exception is the removal of the 
> somewhat exotic unwrapping of temporary arrays in the static initializer of 
> `impl/FtpClient`.
> 
> Testing: `test/jdk/sun/net/ftp` run green. GHA results pending.

Looks fine to me as well. I checked the FTP specific tests and they pass. But, 
would be good to run all of tier2.

-------------

Marked as reviewed by michaelm (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22105#pullrequestreview-2436826838

Reply via email to