On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> Please review this JEP486 cleanup PR in the > `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes. > > * The `MailToURLConnection::getPermission` override with the related > `permission` field is removed > * The SM property access check in `MailToURLConnection::getFromAddress` is > removed > * The `SmtpClient` use of `GetPropertyAction` is replaced with plain > `System::getProperty` > > As a side note I have been programming Java since 1998 and I was not aware > that this very limited (untested?) mechanism for sending email existed in the > JDK. Unless it is in extensive use, perhaps we should consider deprecating it > somehow. Superior alternatives exist. Thanks Eirik. I ran tier2 on our CI too and didn't spot any error. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22138#pullrequestreview-2438844338
