On Wed, 20 Nov 2024 13:46:59 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Implemented in 424fc8ccd3a495a49f859f0cfc563cf463b3efeb, along with a test. >> Are you sure we want to have a `close()` there instead of `closeQuietly()`? > > I can't think of any cases where close could throw here but it would be > better to catch any exception or error from close so that it doesn't override > the UHE. A supporting method to catch and add as a suppressed exception is > okay but maybe think more about the name as "quietly" it misleading, and > "parentError" is a bit strange as it's not an Error. In a21c5e068555dc99e72d63ab29d3fbe75a543080, * Renamed `closeQuietly()` to `closeSuppressingExceptions()` * Replaced the `close()` usage with `closeSuppressingExceptions()` where we throw `UHE` in `connect()` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1850361359
